| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Feb 2014 14:33:23 +1100 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52F8399B.3050204@xxxxxxxxxxx> |
| References: | <52F83630.4020008@xxxxxxxxxx> <52F8399B.3050204@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Feb 09, 2014 at 08:29:47PM -0600, Eric Sandeen wrote: > Many/most callers of xfs_update_cksum() pass bp->b_addr and > BBTOB(bp->b_length) as the first 2 args. Add a helper > which can just accept the bp and the crc offset, and work > it out on its own, for brevity. The title of the patch is the same as the previous one - I think you forgot to "update" it? Other than that, same comments as for the previous patch. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/6] xfs: add helper for verifying checksums on xfs_bufs, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs, Eric Sandeen |
| Previous by Thread: | [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs, Eric Sandeen |
| Next by Thread: | Re: [PATCH 4/6] xfs: add helper for verifying checksums on xfs_bufs, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |