| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 6/8] xfs: use xfs_icluster_size_fsb in xfs_ialloc_inode_init |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Dec 2013 03:14:37 -0800 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52A96809.9020702@xxxxxxxxxx> |
| References: | <52A96809.9020702@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> + * Loop over the new block(s), filling in the inodes. For small block > + * sizes, manipulate the inodes in buffers which are multiples of the > + * blocks size. > */ > + blks_per_cluster = xfs_icluster_size_fsb(mp); > + inodes_per_cluster = blks_per_cluster << mp->m_sb.sb_inopblog; > + nbufs = length / blks_per_cluster; I don't think there's a point to have the nbufs variable as it's used just once as the loop termination condition. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2 7/8] xfs: use xfs_icluster_size_fsb in xfs_ifree_cluster, Christoph Hellwig |
| Previous by Thread: | [PATCH v2 6/8] xfs: use xfs_icluster_size_fsb in xfs_ialloc_inode_init, Jeff Liu |
| Next by Thread: | Re: [PATCH v2 6/8] xfs: use xfs_icluster_size_fsb in xfs_ialloc_inode_init, Jeff Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |