Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error.

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 13 Dec 2013 03:01:28 -0800
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20131212222438.GJ10988@dastard>
References:	<1386826478-13846-1-git-send-email-david@xxxxxxxxxxxxx> <1386826478-13846-2-git-send-email-david@xxxxxxxxxxxxx> <20131212163629.GA2894@xxxxxxxxxxxxx> <20131212222438.GJ10988@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Dec 13, 2013 at 09:24:38AM +1100, Dave Chinner wrote:
> Ok, I agree it is a bit messy, but that code is already pretty ugly.
> I'd like to get this fix in first, because it's causing oopses in
> roughly 30% of my local xfstests runs on a couple of VMs, so I'd
> prefer to get the fix out there now and do the cleanup as a separate
> patch series. Would that be an acceptible approach to take here from
> your perspective?

Ok, let's put the minimal fix in for now and then sort it out.  I'll
re-review it carefully.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly, (continued) Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly, Ben Myers Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly, Dave Chinner Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly, Ben Myers [PATCH 2/6] xfs: prevent spurious "head behind tail" warnings, Dave Chinner [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Dave Chinner Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Jeff Liu Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Dave Chinner Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Jeff Liu Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Christoph Hellwig Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Dave Chinner Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Christoph Hellwig <= Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Christoph Hellwig Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Ben Myers [PATCH v2] xfs: remove xfsbdstrat error., Christoph Hellwig [PATCH 5/6] xfs: xlog_recover_process_data leaks like a sieve, Dave Chinner Re: [PATCH 5/6] xfs: xlog_recover_process_data leaks like a sieve, Christoph Hellwig Re: [PATCH 5/6] xfs: xlog_recover_process_data leaks like a sieve, Dave Chinner Re: [PATCH 5/6] xfs: xlog_recover_process_data leaks like a sieve, Christoph Hellwig Re: [PATCH 5/6] xfs: xlog_recover_process_data leaks like a sieve, Mark Tinguely [PATCH 3/6] xfs: prevent spurious "space > BBTOB(tail_blocks)" warnings, Dave Chinner [PATCH 6/6] xfs: abort metadata writeback on permanent errors, Dave Chinner

Previous by Date:	Re: XFS / writeback invoking soft lockup., Dave Chinner
Next by Date:	Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Christoph Hellwig
Previous by Thread:	Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Dave Chinner
Next by Thread:	Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error., Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]