| To: | Junho Ryu <jayr@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Dec 2013 10:00:37 +1100 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, tytso@xxxxxxx, Boris Ranto <branto@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <CAFA30n_-s1uMeQ0k2EoawY4NzMSiqkH+tHze9rASej2RoM_TjA@xxxxxxxxxxxxxx> |
| References: | <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-7-git-send-email-jayr@xxxxxxxxxx> <20131211074657.GF19248@xxxxxxxxxxxxx> <20131211224229.GK10988@dastard> <20131212180144.GB19422@xxxxxxxxxxxxx> <CAFA30n_-s1uMeQ0k2EoawY4NzMSiqkH+tHze9rASej2RoM_TjA@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 12, 2013 at 02:44:47PM -0800, Junho Ryu wrote: > >> I'd just rename if _require_fiemap, because we need both xfs_io and > >> kernel support for it, and we need xfs_io support to check for > >> kernel support.... > > > > Fine with me. > > There are 3 more _require_xfs_io_.* functions. I can create another > patch if you want these names to be consistent. > > _require_xfs_io_falloc() > _require_xfs_io_falloc_punch() yes, those 2 can be changed similar to _requires_fiemap > _require_xfs_io_zero() That one is only testing for xfs_io command support, so it should remain the way it is... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/4 v3] fiemap: add EXTENT_DATA_COMPRESSED flag, Dave Chinner |
| Previous by Thread: | Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support, Junho Ryu |
| Next by Thread: | [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Junho Ryu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |