| To: | Junho Ryu <jayr@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount. |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 10 Dec 2013 23:46:15 -0800 |
| Cc: | xfs@xxxxxxxxxxx, tytso@xxxxxxx, hughd@xxxxxxxxxx, branto@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> |
| References: | <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Dec 10, 2013 at 12:11:56PM -0800, Junho Ryu wrote: > Several tests unmount then re-mount the scratch filesystem, to check > that the content is unchanged; but unmounting a tmpfs is designed to > lose its content, which causes such tests to fail unnecessarily. Add > _scratch_remount(), which instead uses remount on a tmpfs to preserve > its contents. Also add _test_remount() to do the same for the test > device. All these tests don't make sense if you never unmount the filesystem. Istead they should exit with _notrun for tmpfs. |
| Previous by Date: | Re: [PATCH 04/10] xfstests: increase tmpfs memory size, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support, Christoph Hellwig |
| Previous by Thread: | [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Junho Ryu |
| Next by Thread: | Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount., Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |