| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsdump: don't assume getdents exists |
| From: | Kyle McMartin <kmcmarti@xxxxxxxxxx> |
| Date: | Tue, 10 Dec 2013 14:50:12 -0500 |
| Cc: | sandeen@xxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52A72930.4020404@xxxxxxxxxxx> |
| References: | <20131106213635.GC24712@xxxxxxxxxxxxxxxxxxxxxxx> <52A72930.4020404@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Dec 10, 2013 at 08:46:08AM -0600, Eric Sandeen wrote: > On 11/6/13, 3:36 PM, Kyle McMartin wrote: > > New Linux ports are using a standard syscall list that does not include > > deprecated syscalls where 64-bit clean alternatives exist. As a result, > > on arm64, __NR_getdents is undefined, resulting in xfsdump failing to > > build. > > > > To avoid that, in the case where __NR_getdents is unset in unistd.h, > > avoid building the fallback path entirely, since > > __ASSUME_GETDENTS64_SYSCALL will be true, the SYS_getdents64 case will > > be the primary (and only) path used. > > > > Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx> > > Hey Kyle - were you going to do a V2 of this one? > > Just checking, thanks - > -Eric > Yeah, I can do that today. Thanks Eric. --Kyle |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [GIT PULL] XFS bugfixes for 3.13-rc4, Ben Myers |
|---|---|
| Next by Date: | [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs, Junho Ryu |
| Previous by Thread: | Re: [PATCH] xfsdump: don't assume getdents exists, Eric Sandeen |
| Next by Thread: | [XFS updates] XFS development tree branch, master, updated. xfs-for-linus-v3.13-rc1-2-13376-gdf8052e, xfs |
| Indexes: | [Date] [Thread] [Top] [All Lists] |