| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/11] xfs: rename xfs_ilock_map_shared |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 9 Dec 2013 18:24:28 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131209070316.GA27054@xxxxxxxxxxxxx> |
| References: | <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> <20131206203128.511935311@xxxxxxxxxxxxxxxxxxxxxx> <20131208223359.GD31386@dastard> <20131209070316.GA27054@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Dec 08, 2013 at 11:03:16PM -0800, Christoph Hellwig wrote: > On Mon, Dec 09, 2013 at 09:33:59AM +1100, Dave Chinner wrote: > > While we are changing this, I think it makes sense to move it to > > being a static inline function given how simple it is.... > > I actually tried that first, but with XFS_DINODE_FMT_BTREE in > fs/xfs/xfs_dinode.h, struct xfsicdinode in xfs_log_format.h > and the resulting dependencies it didn't seem workable. My inode > reshuffle might provide relief eventually. Ok, makes sense to leave it like that for the moment. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | британская соль способствует похудеть?, Lynda |
|---|---|
| Next by Date: | Bezkosztowa wymiana linkami, Agnieszka Nowak |
| Previous by Thread: | Re: [PATCH 03/11] xfs: rename xfs_ilock_map_shared, Christoph Hellwig |
| Next by Thread: | [PATCH 10/11] xfs: use xfs_ilock_attr_map_shared in xfs_attr_list_int, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |