| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 08/11] xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 06 Dec 2013 12:30:14 -0800 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| References: | <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | quilt/0.60-1 |
We might not have read in the extent list at this point, so make sure we
take the ilock exclusively if we have to do so.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Index: xfs/fs/xfs/xfs_qm.c
===================================================================
--- xfs.orig/fs/xfs/xfs_qm.c 2013-12-06 17:20:27.491331600 +0100
+++ xfs/fs/xfs/xfs_qm.c 2013-12-06 19:39:27.251160455 +0100
@@ -1193,16 +1193,18 @@ xfs_qm_dqiterate(
lblkno = 0;
maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes);
do {
+ uint lock_mode;
+
nmaps = XFS_DQITER_MAP_SIZE;
/*
* We aren't changing the inode itself. Just changing
* some of its data. No new blocks are added here, and
* the inode is never added to the transaction.
*/
- xfs_ilock(qip, XFS_ILOCK_SHARED);
+ lock_mode = xfs_ilock_data_map_shared(qip);
error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno,
map, &nmaps, 0);
- xfs_iunlock(qip, XFS_ILOCK_SHARED);
+ xfs_iunlock(qip, lock_mode);
if (error)
break;
|
| Previous by Date: | [PATCH 10/11] xfs: use xfs_ilock_attr_map_shared in xfs_attr_list_int, Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH 07/11] xfs: use xfs_ilock_data_map_shared in xfs_qm_dqtobp, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 10/11] xfs: use xfs_ilock_attr_map_shared in xfs_attr_list_int, Dave Chinner |
| Next by Thread: | Re: [PATCH 08/11] xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |