Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Dec 04, 2013 at 12:12:37PM +0000, Steven Whitehouse wrote:
> >             error = posix_acl_equiv_mode(acl, &mode);
> > +           if (error < 0)
> >  
> Andy Price has pointed out a missing "return error;" here
> 
> > -           if (error <= 0) {
> > -                   posix_acl_release(acl);
> > +           if (error == 0)
> >                     acl = NULL;
> >  
> > -                   if (error < 0)
> > -                           return error;
> > -           }
> > -
> 
> Also, there seems to be a white space error in the xfs patch around line
> 170 in fs/xfs/xfs_iops.c where there is an added "if (default_acl)" with
> a space before the tab,

I'll take care of these for the next version.