| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 5/7] xfs: use xfs_ilock_map_shared in xfs_attr_get |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 06 Dec 2013 08:48:24 -0800 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| References: | <20131206164819.371654241@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | quilt/0.60-1 |
We might not have read in the extent list at this point, so make sure we
take the ilock exclusively if we have to do so.
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Index: xfs/fs/xfs/xfs_attr.c
===================================================================
--- xfs.orig/fs/xfs/xfs_attr.c 2013-12-05 22:19:26.087829792 +0100
+++ xfs/fs/xfs/xfs_attr.c 2013-12-05 22:23:54.307824288 +0100
@@ -164,6 +164,7 @@ xfs_attr_get(
{
int error;
struct xfs_name xname;
+ uint lock_mode;
XFS_STATS_INC(xs_attr_get);
@@ -174,9 +175,9 @@ xfs_attr_get(
if (error)
return error;
- xfs_ilock(ip, XFS_ILOCK_SHARED);
+ lock_mode = xfs_ilock_map_shared(ip);
error = xfs_attr_get_int(ip, &xname, value, valuelenp, flags);
- xfs_iunlock(ip, XFS_ILOCK_SHARED);
+ xfs_iunlock_map_shared(ip, lock_mode);
return(error);
}
|
| Previous by Date: | [PATCH 7/7] xfs: assert that we hold the ilock for extent map access, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 1/7] xfs: reinstate the ilock in xfs_readdir, Christoph Hellwig |
| Previous by Thread: | [PATCH 7/7] xfs: assert that we hold the ilock for extent map access, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 0/7] extent list locking fixes V2, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |