| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: don't perform discard if the given range length is less than block size |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Wed, 4 Dec 2013 15:55:06 -0600 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <528C6E15.3030801@xxxxxxxxxx> |
| References: | <528C6E15.3030801@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Nov 20, 2013 at 04:08:53PM +0800, Jeff Liu wrote: > From: Jie Liu <jeff.liu@xxxxxxxxxx> > > For discard operation, we should return EINVAL if the given range length > is less than a block size, otherwise it will go through the file system > to discard data blocks as the end range might be evaluated to -1, e.g, > # fstrim -v -o 0 -l 100 /xfs7 > /xfs7: 9811378176 bytes were trimmed > > This issue can be triggered via xfstests/generic/288. > > Also, it seems to get the request queue pointer via bdev_get_queue() > instead of the hard code pointer dereference is not a bad thing. > > Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> Applied this. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin, Ben Myers |
|---|---|
| Next by Date: | [XFS updates] XFS development tree branch, master, updated. xfs-for-linus-v3.13-rc1-2-13365-gf9fd013, xfs |
| Previous by Thread: | Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin, Ben Myers |
| Next by Thread: | [XFS updates] XFS development tree branch, master, updated. xfs-for-linus-v3.13-rc1-2-13365-gf9fd013, xfs |
| Indexes: | [Date] [Thread] [Top] [All Lists] |