| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fs: fix iversion handling |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Wed, 4 Dec 2013 15:25:04 -0600 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131119151707.GA13412@xxxxxxxxxxxxx> |
| References: | <20131119151707.GA13412@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
Hey Christoph, On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote: > Currently notify_change directly updates i_version for size updates, > which not only is counter to how all other fields are updated through > struct iattr, but also breaks XFS, which need inode updates to happen > under its own lock, and synchronized to the structure that gets written > to the log. > > Remove the update in the common code, and it to btrfs and ext4, > XFS already does a proper updaste internally and currently gets a > double update with the existing code. > > IMHO this is 3.13 and -stable material and should go in through the XFS > tree. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Does this still need a btrfs ack, or is it ready to go? -Ben |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v3] xfs: fix memory leak in xfs_dir2_node_removename, Ben Myers |
|---|---|
| Next by Date: | Nouveau siège social Les Nouveaux Constructeurs, Les Nouveaux Constructeurs |
| Previous by Thread: | Re: [PATCH] fs: fix iversion handling, Dave Chinner |
| Next by Thread: | Re: [PATCH] fs: fix iversion handling, Chris Mason |
| Indexes: | [Date] [Thread] [Top] [All Lists] |