| To: | Andreas Dilger <adilger@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fs: fix iversion handling |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Dec 2013 01:39:44 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <8E57B1B6-E650-4A1A-AF78-0A9C9593A3E3@xxxxxxxxx> |
| References: | <20131119151707.GA13412@xxxxxxxxxxxxx> <20131202173636.GA17724@xxxxxxxxxxxxx> <8E57B1B6-E650-4A1A-AF78-0A9C9593A3E3@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 02, 2013 at 03:05:07PM -0700, Andreas Dilger wrote:
> >> */
> >> - if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME))))
> >> - inode->i_ctime = inode->i_mtime = current_fs_time(inode->i_sb);
> >> + if (newsize != oldsize) {
> >> + inode_inc_iversion(inode);
>
> Should this be conditional on IS_I_VERSION(inode)?
btrfs sets MS_I_VERSION unconditionally.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] fs: fix iversion handling, Boaz Harrosh |
|---|---|
| Next by Date: | Re: [PATCH 04/15] mkfs: validate all input values, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] fs: fix iversion handling, Andreas Dilger |
| Next by Thread: | Re: [PATCH] fs: fix iversion handling, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |