| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/10] xfs: introduce xlog_copy_iovec |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Dec 2013 12:21:20 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131129084000.853201203@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20131129083919.207915844@xxxxxxxxxxxxxxxxxxxxxx> <20131129084000.853201203@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 29, 2013 at 12:39:24AM -0800, Christoph Hellwig wrote: > Add a helper to abstract out filling the log iovecs in the log item format > handlers. This will allow us to change the way we do the log item > formatting more easily. > > The copy in the name is a bit confusing for now as it just assigns a > pointer and lets the CIL code perform the copy, but that will change > soon. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good - I think the helper was worth the effort. ;) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/10] xfs: refactor xfs_inode_item_format, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 06/15] mkfs: validate logarithmic parameters sanely, Michael L. Semon |
| Previous by Thread: | Re: [PATCH 04/10] xfs: refactor xfs_inode_item_format, Dave Chinner |
| Next by Thread: | Re: [PATCH 05/10] xfs: introduce xlog_copy_iovec, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |