Re: [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project quotas off

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Fri, Nov 29, 2013 at 03:03:36PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Introduce xfs/323 to verify that turn group/project quotas off
> while user quotas is on.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

One minor thing:

> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +
> +_require_scratch
> +_require_xfs_quota
> +_require_xfs_crc_sb
> +
> +_qmount_option "uquota,gquota,pquota"
> +_qmount
> +
> +TESTDIR=$SCRATCH_MNT/testdir

Too similar to TEST_DIR. "quota_dir", or something like it, so
people don't get confused by what device this test is running on at
a glance.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx