Re: [PATCH 31/37] db: Unwind the IO stack on exit

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 31/37] db: Unwind the IO stack on exit
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 7 Nov 2013 12:55:58 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383700043-32305-32-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-32-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Nov 06, 2013 at 12:07:17PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db can build up a large IO stack by the time it has run to
> completion. If we don't unwind this IO stack before we shut down the
> libxfs caches, metadump and other db programs will exit with
> unreleased buffers and emit warnings like:
> 
> cache_purge: shake on cache 0x69e4f0 left 7 nodes!?
> 
> Hence we need to unwind the iostack as we shut down.

Seems like this should be folded into patch 20, as that adds the
first pop, but it seems to fail goind all the way.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 27/37] db: re-enable write support for v5 filesystems., (continued) [PATCH 27/37] db: re-enable write support for v5 filesystems., Dave Chinner [PATCH 23/37] db: verify and calculate inode CRCs, Dave Chinner [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Dave Chinner Re: [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Christoph Hellwig [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Dave Chinner Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Christoph Hellwig [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner Re: [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner Re: [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Christoph Hellwig [PATCH 31/37] db: Unwind the IO stack on exit, Dave Chinner Re: [PATCH 31/37] db: Unwind the IO stack on exit, Christoph Hellwig <= [PATCH 25/37] db: add a special directory buffer verifier, Dave Chinner [PATCH 22/37] db: indicate if the CRC on a buffer is correct or not, Dave Chinner [PATCH 18/37] db: rewrite bbmap to use xfs_buf_map, Dave Chinner [PATCH 16/37] libxfs: stop caching inode structures, Dave Chinner [PATCH 13/37] xfs: fix node forward in xfs_node_toosmall, Dave Chinner [PATCH 12/37] xfs: fix the wrong new_size/rnew_size at xfs_iext_realloc_direct(), Dave Chinner [PATCH 29/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner Re: [PATCH 29/37] xfs_db: avoid libxfs buffer lookup warnings, Christoph Hellwig [PATCH 09/37] libxfs: bring across inode buffer readahead verifier changes, Dave Chinner [PATCH 33/37] xfs: support larger inode clusters on v5 filesystems, Dave Chinner

Previous by Date:	Re: [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Christoph Hellwig
Next by Date:	Re: xfstest failures, Christoph Hellwig
Previous by Thread:	[PATCH 31/37] db: Unwind the IO stack on exit, Dave Chinner
Next by Thread:	[PATCH 25/37] db: add a special directory buffer verifier, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]