Re: [PATCH 37/37] repair: fix leaf node directory data check

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 37/37] repair: fix leaf node directory data check
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 6 Nov 2013 02:39:10 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383700043-32305-38-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-38-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Nov 06, 2013 at 12:07:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When walking the leaf node format blocks (LEAFN) in the hash index
> of a large directory, we could trip over btree node blocks (DA_NODE)
> in the address space if there are enough entries in the directory.
> These cause a verifier failure, and hence the directory is
> considered corrupt and is trashed and rebuilt unnecesarily. Fix this
> by using the correct verifier that can handle both types of blocks
> without triggering failures.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 04/37] xfs: split dquot buffer operations out, (continued) [PATCH 04/37] xfs: split dquot buffer operations out, Dave Chinner [PATCH 34/37] xfsprogs: kill experimental warnings for v5 filesystems, Dave Chinner [PATCH 14/37] xfs: don't emit corruption noise on fs probes, Dave Chinner [PATCH 07/37] libxfs: bmap btree owner swap support, Dave Chinner [PATCH 05/37] xfs: decouple inode and bmap btree header files, Dave Chinner [PATCH 24/37] db: verify and calculate dquot CRCs, Dave Chinner [PATCH 26/37] db: add a special attribute buffer verifier, Dave Chinner [PATCH 03/37] xfs: create a shared header file for format-related information, Dave Chinner [PATCH 20/37] db: rewrite IO engine to use libxfs, Dave Chinner [PATCH 37/37] repair: fix leaf node directory data check, Dave Chinner Re: [PATCH 37/37] repair: fix leaf node directory data check, Christoph Hellwig <= [PATCH 17/37] db: separate out straight buffer IO from map based IO., Dave Chinner Re: [PATCH 17/37] db: separate out straight buffer IO from map based IO., Christoph Hellwig [PATCH 32/37] db: enable metadump on CRC filesystems, Dave Chinner [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig [PATCH 21/37] db: introduce verifier support into set_cur, Dave Chinner [PATCH 35/37] repair: prefetching is turned off unnecessarily, Dave Chinner

Previous by Date:	[PATCH] xfsprogs: add generated crc files to .gitignore, Christoph Hellwig
Next by Date:	Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig
Previous by Thread:	[PATCH 37/37] repair: fix leaf node directory data check, Dave Chinner
Next by Thread:	[PATCH 17/37] db: separate out straight buffer IO from map based IO., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]