Re: [PATCH 16/30] db: rewrite bbmap to use xfs_buf

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 31 Oct 2013 08:06:22 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383107481-28937-17-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-17-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Oct 30, 2013 at 03:31:07PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Use the libxfs struct xfs_buf_map for recording the extent layout of
> discontiguous buffers and convert the read/write to decode them
> directory and use read_buf/write_buf to do the extent IO. This
> brings the physical xfs_db IO code to be very close to the model
> that libxfs uses.

Looks reasonable.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/30 V3] xfsprogs: CRC write support for xfs_db, Dave Chinner [PATCH 09/30] libxfs: bring across inode buffer readahead verifier changes, Dave Chinner Re: [PATCH 09/30] libxfs: bring across inode buffer readahead verifier changes, Christoph Hellwig [PATCH 27/30] libxfs: work around do_div() not handling 32 bit numerators, Dave Chinner [PATCH 01/30] xfsprogs: fix automatic dependency generation, Dave Chinner Re: [PATCH 01/30] xfsprogs: fix automatic dependency generation, Christoph Hellwig [PATCH 28/30] db: enable metadump on CRC filesystems, Dave Chinner [PATCH 02/30] xfs: fix some minor sparse warnings, Dave Chinner Re: [PATCH 02/30] xfs: fix some minor sparse warnings, Christoph Hellwig [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map, Dave Chinner Re: [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map, Christoph Hellwig <= [PATCH 03/30] xfs: create a shared header file for format-related information, Dave Chinner Re: [PATCH 03/30] xfs: create a shared header file for format-related information, Christoph Hellwig [PATCH 04/30] xfs: split dquot buffer operations out, Dave Chinner Re: [PATCH 04/30] xfs: split dquot buffer operations out, Christoph Hellwig [PATCH 21/30] db: verify and calculate dquot CRCs, Dave Chinner [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code, Dave Chinner Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code, Christoph Hellwig [PATCH 29/30] xfs: support larger inode clusters on v5 filesystems, Dave Chinner [PATCH 30/30] xfsprogs: kill experimental warnings for v5 filesystems, Dave Chinner [PATCH 05/30] xfs: decouple inode and bmap btree header files, Dave Chinner

Previous by Date:	Re: [PATCH 25/30 V2] libxfs: fix root inode handling inconsistencies, Christoph Hellwig
Next by Date:	Re: [PATCH 17/30] db: rewrite IO engine to use libxfs, Christoph Hellwig
Previous by Thread:	[PATCH 16/30] db: rewrite bbmap to use xfs_buf_map, Dave Chinner
Next by Thread:	[PATCH 03/30] xfs: create a shared header file for format-related information, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map