Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 31 Oct 2013 07:46:23 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383107481-28937-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Oct 30, 2013 at 03:30:57PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The libxfs/xfs_btree.c code does not contain a small amount of code
> for btree block readahead that the kernel code does. Instead, it
> short circuits it at a higher layer and doesn't include the lower
> layer functions. There is no harm in calling the lower lay functions
> and have them do nothing, and doing so unifies the kernel and
> userspace code.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/30] xfs: fix some minor sparse warnings, (continued) [PATCH 02/30] xfs: fix some minor sparse warnings, Dave Chinner Re: [PATCH 02/30] xfs: fix some minor sparse warnings, Christoph Hellwig [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map, Dave Chinner Re: [PATCH 16/30] db: rewrite bbmap to use xfs_buf_map, Christoph Hellwig [PATCH 03/30] xfs: create a shared header file for format-related information, Dave Chinner Re: [PATCH 03/30] xfs: create a shared header file for format-related information, Christoph Hellwig [PATCH 04/30] xfs: split dquot buffer operations out, Dave Chinner Re: [PATCH 04/30] xfs: split dquot buffer operations out, Christoph Hellwig [PATCH 21/30] db: verify and calculate dquot CRCs, Dave Chinner [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code, Dave Chinner Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code, Christoph Hellwig <= [PATCH 29/30] xfs: support larger inode clusters on v5 filesystems, Dave Chinner [PATCH 30/30] xfsprogs: kill experimental warnings for v5 filesystems, Dave Chinner [PATCH 05/30] xfs: decouple inode and bmap btree header files, Dave Chinner Re: [PATCH 05/30] xfs: decouple inode and bmap btree header files, Christoph Hellwig [PATCH 20/30] db: verify and calculate inode CRCs, Dave Chinner [PATCH 23/30] db: add a special attribute buffer verifier, Dave Chinner [PATCH 15/30] db: separate out straight buffer IO from map based IO., Dave Chinner Re: [PATCH 15/30] db: separate out straight buffer IO from map based IO., Christoph Hellwig Re: [PATCH 15/30] db: separate out straight buffer IO from map based IO., Dave Chinner [PATCH 18/30] db: introduce verifier support into set_cur, Dave Chinner

Previous by Date:	Re: [PATCH 05/30] xfs: decouple inode and bmap btree header files, Christoph Hellwig
Next by Date:	Re: [PATCH 07/30] libxfs: bmap btree owner swap support, Christoph Hellwig
Previous by Thread:	[PATCH 06/30] libxfs: unify xfs_btree.c with kernel code, Dave Chinner
Next by Thread:	[PATCH 29/30] xfs: support larger inode clusters on v5 filesystems, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]