Re: [PATCH 13/15] xfs: validity check the directory block leaf entry cou

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 13/15] xfs: validity check the directory block leaf entry count
From:	Ben Myers <bpm@xxxxxxx>
Date:	Tue, 29 Oct 2013 15:43:19 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383045118-31107-14-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383045118-31107-1-git-send-email-david@xxxxxxxxxxxxx> <1383045118-31107-14-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Oct 29, 2013 at 10:11:56PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The directory block format verifier fails to check that the leaf
> entry count is in a valid range, and so if it is corrupted then it
> can lead to derefencing a pointer outside the block buffer. While we
> can't exactly validate the count without first walking the directory
> block, we can ensure the count lands in the valid area within the
> directory block and hence avoid out-of-block references.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/15] xfs: patches for 3.13, Dave Chinner [PATCH 01/15] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Dave Chinner Re: [PATCH 01/15] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Ben Myers Re: [PATCH 01/15] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Dave Chinner [PATCH 15/15] xfs: fix static and extern sparse warnings, Dave Chinner Re: [PATCH 15/15] xfs: fix static and extern sparse warnings, Ben Myers [PATCH 13/15] xfs: validity check the directory block leaf entry count, Dave Chinner Re: [PATCH 13/15] xfs: validity check the directory block leaf entry count, Ben Myers <= [PATCH 02/15] xfs: open code inc_inode_iversion when logging an inode, Dave Chinner [PATCH 03/15] xfs: abstract the differences in dir2/dir3 via an ops vector, Dave Chinner [PATCH 05/15] xfs: vectorise directory data operations, Dave Chinner [PATCH 14/15] xfs: prevent stack overflows from page cache allocation, Dave Chinner Re: [PATCH 14/15] xfs: prevent stack overflows from page cache allocation, Christoph Hellwig Re: [PATCH 14/15] xfs: prevent stack overflows from page cache allocation, Ben Myers [PATCH 08/15] xfs: vectorise DA btree operations, Dave Chinner [PATCH 12/15] xfs: make dir2 ftype offset pointers explicit, Dave Chinner Re: [PATCH 12/15] xfs: make dir2 ftype offset pointers explicit, Ben Myers Re: [PATCH 12/15] xfs: make dir2 ftype offset pointers explicit, Dave Chinner

Previous by Date:	[PATCH 04/23] block: Abstract out bvec iterator, Kent Overstreet
Next by Date:	Re: xfs_repair fatal error -- name create failed in lost+found, filesystem may be out of space, Viet Nguyen
Previous by Thread:	[PATCH 13/15] xfs: validity check the directory block leaf entry count, Dave Chinner
Next by Thread:	[PATCH 02/15] xfs: open code inc_inode_iversion when logging an inode, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]