| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: prevent stack overflows from page cache allocation |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Thu, 24 Oct 2013 11:41:15 -0500 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131024154220.GA19055@xxxxxxxxxxxxx> |
| References: | <1382585110-1796-1-git-send-email-david@xxxxxxxxxxxxx> <20131024084803.GA28144@xxxxxxxxxxxxx> <20131024103751.GS2797@dastard> <20131024154220.GA19055@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
Hey,
On Thu, Oct 24, 2013 at 08:42:20AM -0700, Christoph Hellwig wrote:
> On Thu, Oct 24, 2013 at 09:37:51PM +1100, Dave Chinner wrote:
> > Sure, if you want to. But doing that shouldn't prevent this fix from
> > being committed in the mean time, especially as other filesystems
> > already use this method for avoiding these problems.
>
> I'd much prefer aiming for the proper fix first. If for some reason we
> can't get it done in time the workaround can be applied.
Dave probably has a customer waiting on this. If pulling this in will make a
proper fix more difficult to do I can understand keeping the patch out.
Otherwise, can't we just remove this along with the other filesystems'
equivalent code when the proper fix is committed?
Regards,
Ben
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field, Christoph Hellwig |
|---|---|
| Next by Date: | Re: xfstest 318, Dwight Engen |
| Previous by Thread: | Re: [PATCH] xfs: prevent stack overflows from page cache allocation, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: prevent stack overflows from page cache allocation, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |