Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files
From:	Ben Myers <bpm@xxxxxxx>
Date:	Tue, 22 Oct 2013 13:29:32 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1381789085-21923-10-git-send-email-david@xxxxxxxxxxxxx>
References:	<1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Oct 15, 2013 at 09:17:55AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Currently the xfs_inode.h header has a dependency on the definition
> of the BMAP btree records as the inode fork includes an array of
> xfs_bmbt_rec_host_t objects in it's definition.
> 
> Move all the btree format definitions from xfs_btree.h,
> xfs_bmap_btree.h, xfs_alloc_btree.h and xfs_ialloc_btree.h to
> xfs_format.h to continue the process of centralising the on-disk
> format definitions. With this done, the xfs inode definitions are no
> longer dependent on btree header files.
> 
> The enables a massive culling of unnecessary includes, with close to
> 200 #include directives removed from the XFS kernel code base.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, (continued) Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Eric Sandeen Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Ben Myers [PATCH 01/19] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Dave Chinner [PATCH 04/19] xfs: create a shared header file for format-related information, Dave Chinner Re: [PATCH 04/19] xfs: create a shared header file for format-related information, Ben Myers [PATCH 04/19, V2] xfs: create a shared header file for format-related information, Dave Chinner [PATCH 08/19] xfs: decouple log and transaction headers, Dave Chinner Re: [PATCH 08/19] xfs: decouple log and transaction headers, Ben Myers [PATCH 08/19, V2] xfs: decouple log and transaction headers, Dave Chinner [PATCH 09/19] xfs: decouple inode and bmap btree header files, Dave Chinner Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files, Ben Myers <= [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files, Dave Chinner Re: [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files, Dave Chinner [PATCH 09/19, V3] xfs: decouple inode and bmap btree header files, Dave Chinner [PATCH 19/19] xfs: convert directory vector functions to constants, Dave Chinner Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Dave Chinner Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Dave Chinner Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers

Previous by Date:	Re: [PATCH 08/32] xfs: create a shared header file for format-related information, Rich Johnston
Next by Date:	Re: [PATCH 5/8] xfstests: generic/274 increase scratch fs size to 2g, Rich Johnston
Previous by Thread:	[PATCH 09/19] xfs: decouple inode and bmap btree header files, Dave Chinner
Next by Thread:	[PATCH 09/19, V2] xfs: decouple inode and bmap btree header files, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]