Re: [PATCH 07/19] xfs: remove unused transaction callback variables

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/19] xfs: remove unused transaction callback variables
From:	Ben Myers <bpm@xxxxxxx>
Date:	Tue, 22 Oct 2013 09:25:13 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1381789085-21923-8-git-send-email-david@xxxxxxxxxxxxx>
References:	<1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Oct 15, 2013 at 09:17:53AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> We don't do callbacks at transaction commit time, no do we have any
                                                    nor

> infrastructure to set up or run such callbacks, so remove the
> variables and typedefs for these operations. If we ever need to add
> callbacks, we can reintroduce the variables at that time.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/19 V2] xfs: patches for 3.13, Dave Chinner [PATCH 02/19] xfs: open code inc_inode_iversion when logging an inode, Dave Chinner [PATCH 07/19] xfs: remove unused transaction callback variables, Dave Chinner Re: [PATCH 07/19] xfs: remove unused transaction callback variables, Ben Myers <= [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Dave Chinner Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Eric Sandeen Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Ben Myers [PATCH 01/19] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Dave Chinner [PATCH 04/19] xfs: create a shared header file for format-related information, Dave Chinner Re: [PATCH 04/19] xfs: create a shared header file for format-related information, Ben Myers [PATCH 04/19, V2] xfs: create a shared header file for format-related information, Dave Chinner [PATCH 08/19] xfs: decouple log and transaction headers, Dave Chinner Re: [PATCH 08/19] xfs: decouple log and transaction headers, Ben Myers [PATCH 08/19, V2] xfs: decouple log and transaction headers, Dave Chinner

Previous by Date:	Re: 128 bits extent bmap for file format 2, Greg Freemyer
Next by Date:	Re: [PATCH 05/19] xfs: unify directory/attribute format definitions, Christoph Hellwig
Previous by Thread:	[PATCH 07/19] xfs: remove unused transaction callback variables, Dave Chinner
Next by Thread:	[PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]