| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/16] xfs: decouple inode and bmap btree header files |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 4 Oct 2013 11:00:09 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131003145849.GE10316@xxxxxxxxxxxxx> |
| References: | <1380510433-8353-1-git-send-email-david@xxxxxxxxxxxxx> <1380510433-8353-6-git-send-email-david@xxxxxxxxxxxxx> <20131003145849.GE10316@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 03, 2013 at 07:58:49AM -0700, Christoph Hellwig wrote: > I like this a lot, but it also seems to move the in-core btree records > and keys to the format header which seems wrong. Maybe those should be > centralized in xfs_btree.h instead? Which structures are you talking about here? there's so many key and pointer definitions I'm not sure if there's a specific one you had in mind or whether you mean "all of them"... Keep in mind here that the real dependency problem is the xfs_bmbt_rec_host definition being require by xfs_inode_fork.h. That's an in-core definition, and if we move that to another header file, we simply create a different dependency instead of removing the dependency altogether.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 04/16] xfs: decouple log and transaction headers, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfstests generic/260: get correct trimmed bytes, Dave Chinner |
| Previous by Thread: | Re: [PATCH 05/16] xfs: decouple inode and bmap btree header files, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 05/16] xfs: decouple inode and bmap btree header files, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |