| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/16] xfs: unify directory/attribute format definitions |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 4 Oct 2013 10:47:41 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131003145218.GB10316@xxxxxxxxxxxxx> |
| References: | <1380510433-8353-1-git-send-email-david@xxxxxxxxxxxxx> <1380510433-8353-3-git-send-email-david@xxxxxxxxxxxxx> <20131003145218.GB10316@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 03, 2013 at 07:52:18AM -0700, Christoph Hellwig wrote: > Looks good, but you have some function prototype declarations sneaking > into the format header again. Right, there's a few that are copied over that already exist (e.g. the to/from disk functions). They go away during the vectorisation of the directory operations as all the externally accessed to/from disk encoding is accessed through the xfs_dir_ops vector. Hence this is only a temporary situation through this patchset. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH V2] xfsdump: handle large, wholly-sparse files, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 04/16] xfs: decouple log and transaction headers, Dave Chinner |
| Previous by Thread: | Re: [PATCH 02/16] xfs: unify directory/attribute format definitions, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 03/16] xfs: split dquot buffer operations out, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |