| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: fix some minor sparse warnings |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 2 Sep 2013 20:09:57 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130902081954.GD11210@xxxxxxxxxxxxx> |
| References: | <1378092179-24973-1-git-send-email-david@xxxxxxxxxxxxx> <1378092179-24973-3-git-send-email-david@xxxxxxxxxxxxx> <20130902081954.GD11210@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 02, 2013 at 01:19:54AM -0700, Christoph Hellwig wrote:
> > --- a/fs/xfs/xfs_dquot_item.c
> > +++ b/fs/xfs/xfs_dquot_item.c
> > @@ -143,6 +143,8 @@ STATIC uint
> > xfs_qm_dquot_logitem_push(
> > struct xfs_log_item *lip,
> > struct list_head *buffer_list)
> > + __releases(&lip->li_ailp->xa_lock)
> > + __acquires(&lip->li_ailp->xa_lock)
> > {
>
> Having these markers indented the same amount as the parameters isn't
> very readable. Maybe give them another tab level?
Sure. Can do.
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] xfs: ensure we copy buffer type in da btree root splits, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfsprogs: avoid array overflow in pf_batch_read(), Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/2] xfs: fix some minor sparse warnings, Christoph Hellwig |
| Next by Thread: | [PATCH 2/2 v2] xfs: fix some minor sparse warnings, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |