Re: [PATCH] xfs: check correct status variable for xfs_inobt_get

xfs

Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() c

To:	Brian Foster <bfoster@xxxxxxxxxx>
Subject:	Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 28 Aug 2013 08:47:22 +1000
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1377638145-18800-1-git-send-email-bfoster@xxxxxxxxxx>
References:	<1377638145-18800-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Aug 27, 2013 at 05:15:45PM -0400, Brian Foster wrote:
> The call to xfs_inobt_get_rec() in xfs_dialloc_ag() passes 'j' as
> the output status variable. The immediately following
> XFS_WANT_CORRUPTED_GOTO() checks the value of 'i,' which is from
> the previous lookup call and has already been checked. Fix the
> corruption check to use 'j.'
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Brian Foster Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Eric Sandeen Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Dave Chinner <= Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Ben Myers

Previous by Date:	About your outstanding payment due for release., salliesuyin657
Next by Date:	Re: XFS recovery resumes..., Dave Chinner
Previous by Thread:	Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Eric Sandeen
Next by Thread:	Re: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]