Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Replace roundup() with roundup_64() as we calculate min_logblks
> with 64-bit divisions.  Hence, call roundup() will cause the
> following error while compiling a 32-bit kernel:
> 
> fs/built-in.o: In function `xfs_log_calc_minimum_size':
> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
> 
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Cc: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

You beat me to it, Jeff. I got an email from Fengguang's build farm,
too. :)

Your fix looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx