Re: [PATCH 28/48] libxfs: determine inode size from version number, not struct xfs_dinode

[Ben Myers <bpm@xxxxxxx>]

On Fri, Jun 07, 2013 at 10:25:51AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db does not use the same structure types as libxfs when checking
> inodes, and so cannot determine the size of the inode core by
> passing a struct xfs_dinode to a function. We do, however, know the
> raw version number, so we can pass that instead. Convert the code to
> passing the inode version rather than a structure.
> 
> Note that this should probably be converted in the kernel code as
> well.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>