| To: | Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: splice vs execve lockdep trace. |
| From: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 16 Jul 2013 06:31:40 +0100 |
| Cc: | Dave Jones <davej@xxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <CA+55aFxiGXht8+Dox=C2ezYYf1yMaLAzMYr40j=+peP8j5Ha6w@xxxxxxxxxxxxxx> |
| References: | <20130716015305.GB30569@xxxxxxxxxx> <CA+55aFyLbqJp0-=7=HOF9sKGOHwsa7A7-V76b8tbsnra8Z2=-w@xxxxxxxxxxxxxx> <20130716023847.GA31481@xxxxxxxxxx> <CA+55aFxiGXht8+Dox=C2ezYYf1yMaLAzMYr40j=+peP8j5Ha6w@xxxxxxxxxxxxxx> |
| Sender: | Al Viro <viro@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Jul 15, 2013 at 08:25:14PM -0700, Linus Torvalds wrote: > The "pipe -> cred_guard_mutex" lock chain is pretty direct, and can be > clearly attributed to splicing into /proc. Now, whether that is a > *good* idea or not is clearly debatable, and I do think that maybe we > should just not splice to/from proc files, but that doesn't seem to be > new, and I don't think it's necessarily *broken* per se, it's just > that splicing into /proc seems somewhat unnecessary, and various proc > files do end up taking locks that can be "interesting". FWIW, we might attack that one - after all, we could have ->splice_write() for that guy that would grab cred_guard_mutex, then call splice_from_pipe() with actor that would map/do security_setprocattr/unmap... Said that, considering what it does on write, it really does *not* want to deal with partial writes, so... |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH RESEND] xfs: fix assertion failure in xfs_vm_write_failed(), Jeff Liu |
|---|---|
| Next by Date: | Re: splice vs execve lockdep trace., Dave Chinner |
| Previous by Thread: | Re: splice vs execve lockdep trace., Dave Jones |
| Next by Thread: | Re: splice vs execve lockdep trace., Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |