Re: [PATCH] xfs: Fix the logic check for all quotas being turned off

xfs

Re: [PATCH] xfs: Fix the logic check for all quotas being turned off

To:	Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject:	Re: [PATCH] xfs: Fix the logic check for all quotas being turned off
From:	Ben Myers <bpm@xxxxxxx>
Date:	Thu, 11 Jul 2013 16:41:44 -0500
Cc:	XFS mailing list <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1373497236.6020.36.camel@xxxxxxxxxxxxxxxxxx>
References:	<1373497236.6020.36.camel@xxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Wed, Jul 10, 2013 at 06:00:36PM -0500, Chandra Seetharaman wrote:
> 
> During the review of seperate pquota inode patches, David noticed
> that the test to detect all quotas being turned off was
> incorrect, and hence the block was not freeing all the quota
> information.
> 
> The check made sense in Irix, but in Linux, quota is turned off
> one at a time, which makes the test invalid for Linux.
> 
> This problem existed since XFS was ported to Linux.
> 
> David suggested to fix the problem by detecting when all quotas are
> turned off by checking m_qflags.
> 
> Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

This looks ok to me. 

Reviewed-by: Ben Myers <bpm@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: Fix the logic check for all quotas being turned off, Chandra Seetharaman Re: [PATCH] xfs: Fix the logic check for all quotas being turned off, Ben Myers <=

Previous by Date:	Re: [PATCH v11 2/4] xfs: Start using pquotaino from the superblock., Ben Myers
Next by Date:	[XFS updates] XFS development tree branch, master, updated. for-linus-v3.11-rc1-9-gc31ad43, xfs
Previous by Thread:	[PATCH] xfs: Fix the logic check for all quotas being turned off, Chandra Seetharaman
Next by Thread:	[PATCH v11 0/4] Allow pquota and gquota to be used together, Chandra Seetharaman
Indexes:	[Date] [Thread] [Top] [All Lists]