Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 12 Jun 2013 07:06:49 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1371032567-21772-25-git-send-email-david@xxxxxxxxxxxxx>
References:	<1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-25-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jun 12, 2013 at 08:22:44PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> It is only used in that file, and delayed allocation is only used
> in the kernel. Hence it has to be removed from xfs_bmap.c in
> userspace, so to minimise the differences between kernel and
> userspace, move this function out of xfs_bmap.c.

Why not call it just xfs_punch_delalloc_range?

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, (continued) Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner [PATCH 20/27] xfs: move xfs_getbmap to xfs_extent_ops.c, Dave Chinner [PATCH 17/27] xfs: split out attribute fork truncation code into separate file, Dave Chinner [PATCH 12/27] xfs: Use inode create transaction, Dave Chinner [PATCH 23/27] xfs: sync minor header differences needed by userspace., Dave Chinner [PATCH 14/27] xfs: move getdents code into it's own file, Dave Chinner [PATCH 22/27] xfs: move xfs_trans_reservations to xfs_trans.h, Dave Chinner [PATCH 21/27] xfs: introduce xfs_sb.c for sharing with libxfs, Dave Chinner [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Dave Chinner Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Christoph Hellwig <= Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Dave Chinner [PATCH 26/27] xfs: minor cleanups, Dave Chinner [PATCH 27/27] xfs: fix issues that cause userspace warnings, Dave Chinner Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings, Brian Foster Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings, Dave Chinner [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Christoph Hellwig Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Christoph Hellwig Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner

Previous by Date:	Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Christoph Hellwig
Next by Date:	Re: [PATCH 00/27] xfs: current patch queue for 3.11, Ben Myers
Previous by Thread:	[PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Dave Chinner
Next by Thread:	Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c