Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 12 Jun 2013 07:05:19 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1371032567-21772-19-git-send-email-david@xxxxxxxxxxxxx>
References:	<1371032567-21772-1-git-send-email-david@xxxxxxxxxxxxx> <1371032567-21772-19-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jun 12, 2013 at 08:22:38PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The core xfs inode operations such as locking, allocation, reading
> and writing are not shared with userspace. However, much of the
> remaining internal inode code such as the incore extent tracking and
> formatting is. Split the XFS inode operations out into a new
> xfs_inode_iops.c file to minimise the differences between the files
> shred with userspace.

Having struct xfs_inode in an xfs_inode_ops.h file while xfs_inode.h
is still around strikes me as extremely odd.  It seems like icdinode
should be in xfs_inode_item.h as is part of the log format primarily.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 27/27] xfs: fix issues that cause userspace warnings, (continued) [PATCH 27/27] xfs: fix issues that cause userspace warnings, Dave Chinner Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings, Brian Foster Re: [PATCH 27/27] xfs: fix issues that cause userspace warnings, Dave Chinner [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Christoph Hellwig Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Christoph Hellwig Re: [PATCH 19/27] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c, Dave Chinner [PATCH 25/27] xfs: split out transaction reservation code, Dave Chinner [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Christoph Hellwig <= Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Christoph Hellwig Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Ben Myers Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Ben Myers Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner Re: [PATCH 00/27] xfs: current patch queue for 3.11, Brian Foster Re: [PATCH 00/27] xfs: current patch queue for 3.11, Dave Chinner Re: [PATCH 00/27] xfs: current patch queue for 3.11, Ben Myers

Previous by Date:	[PATCH] xfstests: print missing utility name, Lukáš Czerner
Next by Date:	Re: [PATCH 24/27] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c, Christoph Hellwig
Previous by Thread:	[PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner
Next by Thread:	Re: [PATCH 18/27] xfs: split out xfs inode operations into separate file, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]