| To: | Rich Johnston <rjohnston@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: Fix test wildcard expansion. |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 31 May 2013 08:12:11 +1000 |
| Cc: | xfstests <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <51A7CC6B.3030607@xxxxxxx> |
| References: | <51A7CC6B.3030607@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, May 30, 2013 at 05:02:19PM -0500, Rich Johnston wrote: > > Before commit 38d58591 "xfstests: fix typo in check", > check xfs/[0-9]?? would execute all tests/xfs/[0-9]?? because: > > 'if grep "^$testname" $group_file >/dev/null' > returns the contents of $group_file because $testname="". > > Therefore xfs/[0-9]?? was echoed to $tmp.list > > Fix the parsing in check to expand the regular expressions for test names. I just fixed this locally myself: - if grep "^$test_name" $group_file >/dev/null ; then + if egrep "^$test_name" $group_file >/dev/null ; then Which just tells grep to treat the pattern as an extended regex.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfstests: Fix test wildcard expansion., Rich Johnston |
|---|---|
| Next by Date: | Re: [PATCH 1/3] 285: Fix test for ext4 in some configurations, Dave Chinner |
| Previous by Thread: | [PATCH] xfstests: Fix test wildcard expansion., Rich Johnston |
| Next by Thread: | Re: [PATCH V2] xfstests: Fix test wildcard expansion., Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |