| To: | Itaru Kitayama <itaru.kitayama@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests comma separated group names |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 21 May 2013 10:45:53 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <CANW9uytQDPaBr_VAGMuwSqhStCfyMCGmV_A3ccNzOExi-KeZfQ@xxxxxxxxxxxxxx> |
| References: | <CANW9uytRpGXcd9x=HWMEoFvd3_9G98CN_Tv3YacTtd1h+Gq=4g@xxxxxxxxxxxxxx> <20130520113045.GB24543@dastard> <CANW9uytQDPaBr_VAGMuwSqhStCfyMCGmV_A3ccNzOExi-KeZfQ@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, May 20, 2013 at 08:42:35PM +0900, Itaru Kitayama wrote: > Yes, we can do that, but I just thought as you originally proposed last year > > -g rw,attr reads better. Agreed, it does read better and is easily to type. That's what you need to put in the commit message - why it is better than what we currently have, and whether it is badwards compatible or not (doesn't break any existing scripts). i.e. the commit message is for telling people -why- the change should be made as we can look at the code to determine -what- the change is. ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 04/14 V2] xfs: avoid nesting transactions in xfs_qm_scall_setqlim(), Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfstests comma separated group names, Itaru Kitayama |
| Previous by Thread: | Re: [PATCH] xfstests comma separated group names, Itaru Kitayama |
| Next by Thread: | Re: [PATCH] xfstests comma separated group names, Itaru Kitayama |
| Indexes: | [Date] [Thread] [Top] [All Lists] |