| To: | Rich Johnston <rjohnston@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Sat, 13 Apr 2013 10:38:29 +1000 |
| Cc: | Wang Sheng-Hui <shhuiw@xxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <51685552.6030808@xxxxxxx> |
| References: | <51678D0D.1070002@xxxxxxxxx> <20130412074034.GC30622@dastard> <5168396C.6020801@xxxxxxxxx> <51685552.6030808@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 12, 2013 at 01:41:22PM -0500, Rich Johnston wrote: > On 04/12/2013 11:42 AM, Wang Sheng-Hui wrote: > > > >Hi Dave, > > > >I introduces Makefile under tests/, which would return to TESTS_SUBDIRS > >with the > >$(dir function. By running find in $(shell, TEST_SUBDIRS will only get > >the dir names, > >and no Makefile. > > > >Regards, > >Sheng-Hui > > Thanks addressing comments and for v2 of this patch. > > I still had issues with Makefile which I corrected at commit time. > > Thanks again for the patch, it has been committed, Rich, it's great that you are picking this stuff up quickly, but as I asked recently, please don't commit patches while there is still an active review conversation going on.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Dave Chinner |
|---|---|
| Next by Date: | Re: xfs_fsr, sunit, and swidth, Dave Chinner |
| Previous by Thread: | Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Rich Johnston |
| Next by Thread: | Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |