| To: | dsterba@xxxxxxx, xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] xfstests: remove unconditional setting of FSTYP |
| From: | David Sterba <dsterba@xxxxxxx> |
| Date: | Thu, 28 Mar 2013 17:48:27 +0100 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130328163738.GE29125@xxxxxxxxxxxxx> |
| Mail-followup-to: | dsterba@xxxxxxx, xfs@xxxxxxxxxxx |
| References: | <1364485147-27210-1-git-send-email-dsterba@xxxxxxx> <20130328163738.GE29125@xxxxxxxxxxxxx> |
| Reply-to: | dsterba@xxxxxxx |
| User-agent: | Mutt/1.5.21 (2012-12-30) |
On Thu, Mar 28, 2013 at 05:37:38PM +0100, David Sterba wrote:
> On Thu, Mar 28, 2013 at 04:39:07PM +0100, David Sterba wrote:
> > Commit 3345d2150e9e672 ("xfstests: clean up and simply check CLI option
> > parsing") hardcodes the FSTYP to xfs, testing other filesystems fails
> > with
> >
> > common.rc: Error: $TEST_DEV (/dev/sda5) is not a MOUNTED xfs filesystem
> >
> > Signed-off-by: David Sterba <dsterba@xxxxxxx>
>
> That's not a complete fix, I haven't noticed the automatic fs detection via
> blkid, however it does not work because HOSTOS is not set:
Simply because HOSTOS is used before common/config is called. There was
one more bug left, FSTYP is not exported so it is set correctly in 'check'
but is not propagated to the subshells with tests.
david
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: remove unconditional setting of FSTYP, David Sterba |
|---|---|
| Next by Date: | [PATCH] xfstests: check: set up config variables before using them, David Sterba |
| Previous by Thread: | Re: [PATCH] xfstests: remove unconditional setting of FSTYP, David Sterba |
| Next by Thread: | [PATCH] xfstests: use BTRFS_UTIL_PROG instead of btrfs, David Sterba |
| Indexes: | [Date] [Thread] [Top] [All Lists] |