| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: skip freelist scans of corrupt agf |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 11 Mar 2013 13:02:05 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <513B5393.4000203@xxxxxxxxxxx> |
| References: | <513B5393.4000203@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, Mar 09, 2013 at 09:21:55AM -0600, Eric Sandeen wrote: > If an agf has bad values in the freelist, this can wreak > havoc if, for example, first > last and the loop > never exits; we index agfl->agfl_bno[i] off into the weeds. > > If they're off, warn about it and skip the scan. > > Thisis done both in xfs_check and xfs_db's freespace cmd. > > Also fix uninit'd variable "i" from previous, similar fix > for xfs_repair. Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: ensure we capture IO errors correctly, Dave Chinner |
|---|---|
| Next by Date: | Re: Concours, panpan2523 |
| Previous by Thread: | [PATCH] xfsprogs: skip freelist scans of corrupt agf, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfsprogs: skip freelist scans of corrupt agf, Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |