Re: [PATCH 07/16] xfs: add CRC checks for quota blocks

[Ben Myers <bpm@xxxxxxx>]

Hi Dave,

On Mon, Feb 25, 2013 at 12:31:32PM +1100, Dave Chinner wrote:
> From: Christoph Hellwig <hch@xxxxxx>
> 
> Use the reserved space in struct xfs_dqblk to store a UUID and a crc
> for the quota blocks.
> 
> [dchinner@xxxxxxxxxx] Add a LSN field and update for current verifier
> infrastructure.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Been over this and it looks fine.

> @@ -897,6 +910,10 @@ xfs_qm_dqiter_bufs(
>               if (error)
>                       break;
>  
> +             /*
> +              * XXX(hch): need to figure out if it makes sense to validate
> +              *           the CRC here.
> +              */

What's you're opinion on this?

-Ben