| To: | Eric Whitney <enwlinux@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: use native definition of O_DIRECT flag |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 27 Feb 2013 09:57:18 +1100 |
| Cc: | xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130226210322.GB5275@wallace> |
| References: | <20130226210322.GB5275@wallace> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 26, 2013 at 04:03:22PM -0500, Eric Whitney wrote: > The definition of O_DIRECT in src/trunc.c causes xfstest 125 to fail > when run on a Pandaboard. On ARM, the value used (0x040000) is > O_DIRECTORY rather than O_DIRECT as it is on x86. Prefer the platform's > native definition of O_DIRECT supplied by fcntl.h if available. Also, > fix a couple of error messages to properly reflect their context. > > Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Read corruption on ARM, Eric Sandeen |
|---|---|
| Next by Date: | Re: Read corruption on ARM, Jason Detring |
| Previous by Thread: | [PATCH] xfstests: use native definition of O_DIRECT flag, Eric Whitney |
| Next by Thread: | Read corruption on ARM, Jason Detring |
| Indexes: | [Date] [Thread] [Top] [All Lists] |