Re: [PATCH 1/2] xfs: use b_maps[] for discontiguous buffers

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Nov 20, 2012 at 04:41:21PM -0600, Mark Tinguely wrote:
> This patch sets all the b_bmap accesses to be b_maps[0]. b_maps[0]
> works for single and multiple segment buffers.
> 
> This fixes a bug where xfs_trans_buf_item_match() could not find a
> multi-segment buffer associated with the transaction because it was
> looking for the block number in the single segment location
> b_map.bm.bn rather than the new generic b_maps[0].bm.bn. This
> resulted in recursive buffer lock that can never be satisfied.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks good, though I agree with Christoph that renaming b_map to
__b_map would be a good idea to prevent future confusion.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx