Re: [PATCH 05/32] xfs: remove xfs_flushinval

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 21 Nov 2012 05:12:27 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20121115205427.GH14281@dastard>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-6-git-send-email-david@xxxxxxxxxxxxx> <20121115162807.GE4019@xxxxxxxxxxxxx> <20121115205427.GH14281@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Nov 16, 2012 at 07:54:27AM +1100, Dave Chinner wrote:
> Yes, I know, but the original patch I had that changed the ranges to
> something sensible was causing fsx and other failures all over the
> place. It appears that setting the ranges appropriately here exposes
> other (worse) bugs, so I decided to leave doing that until I have
> time to go on a wild goose chase....

I'm actually very happy with doing it separately, I just really prefer
comments to be put in place on why it's done the way it is in case we
forget about it again, which history has shown to happen way too often.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 13/32] xfs: verify AGI blocks as they are read from disk, (continued) [PATCH 13/32] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Rich Johnston Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Christoph Hellwig Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner [PATCH 22/32] xfs: factor out dir2 data block reading, Dave Chinner [PATCH 23/32] xfs: factor dir2 leaf read, Dave Chinner [PATCH 05/32] xfs: remove xfs_flushinval_pages, Dave Chinner Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Christoph Hellwig Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Dave Chinner Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Christoph Hellwig <= [PATCH 15/32] xfs: verify inode buffers as they are read from disk, Dave Chinner [PATCH 27/32] xfs: add buffer pre-write callback, Dave Chinner [PATCH 27/32 REPOST] xfs: add buffer pre-write callback, Dave Chinner [PATCH 20/32] xfs: verify dir2 block format buffers, Dave Chinner [PATCH 17/32] xfs: verify dquot blocks as they are read from disk, Dave Chinner [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Mark Tinguely Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Mark Tinguely Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Dave Chinner

Previous by Date:	Re: [PATCH 3/9] xfs: factor out everything but the filemap_write_and_wait from xfs_file_fsync, Christoph Hellwig
Next by Date:	Re: [PATCH 1/3] xfstests: remove unsupported conditionals, Christoph Hellwig
Previous by Thread:	Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Dave Chinner
Next by Thread:	[PATCH 15/32] xfs: verify inode buffers as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages