| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfs: use b_maps[] for discontiguous buffers |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 21 Nov 2012 04:51:13 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20121120224146.376767354@xxxxxxx> |
| References: | <20121120224120.224166649@xxxxxxx> <20121120224146.376767354@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 20, 2012 at 04:41:21PM -0600, Mark Tinguely wrote: > This patch sets all the b_bmap accesses to be b_maps[0]. b_maps[0] > works for single and multiple segment buffers. > > This fixes a bug where xfs_trans_buf_item_match() could not find a > multi-segment buffer associated with the transaction because it was > looking for the block number in the single segment location > b_map.bm.bn rather than the new generic b_maps[0].bm.bn. This > resulted in recursive buffer lock that can never be satisfied. Should b_map be renamed to __b_map so that accesses to it are cought more easily? Also do hyou have a test case for the issue? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02.5/32] xfs: remove xfs_tosspages, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/2] xfs: fix the buffer log format for contiguous buffers, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/2] xfs: use b_maps[] for discontiguous buffers, Mark Tinguely |
| Next by Thread: | Re: [PATCH 1/2] xfs: use b_maps[] for discontiguous buffers, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |