Re: [PATCH 03/32] xfs: remove xfs_wait_on

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 15 Nov 2012 11:23:18 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1352721264-3700-4-git-send-email-david@xxxxxxxxxxxxx>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Nov 12, 2012 at 10:53:55PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> It's just a simple wrapper around a VFS function that is only called
> by another function in xfs_fs_subr.c. Remove it and call the VFS
> function directly.

And what we really should do is call filemap_write_and_wait_range,
but that fits into the later patches better (if you haven't done it
already..)

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 02/32 V2] xfs: remove xfs_tosspages, (continued) Re: [PATCH 02/32 V2] xfs: remove xfs_tosspages, Christoph Hellwig [PATCH 04/32] xfs: remove xfs_flush_pages, Dave Chinner Re: [PATCH 04/32] xfs: remove xfs_flush_pages, Christoph Hellwig [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Rich Johnston Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Christoph Hellwig Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Dave Chinner Re: [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Rich Johnston [PATCH 03/32] xfs: remove xfs_wait_on_pages(), Dave Chinner Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages(), Christoph Hellwig <= [PATCH 10/32] xfs: uncached buffer reads need to return an error, Dave Chinner [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Phil White Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Mark Tinguely [PATCH 09/32] xfs: make buffer read verication an IO completion function, Dave Chinner [PATCH 11/32] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 11/32] xfs: verify superblocks as they are read from disk, Christoph Hellwig [PATCH 14/32] xfs: verify AGFL blocks as they are read from disk, Dave Chinner

Previous by Date:	Re: [PATCH 02/32 V2] xfs: remove xfs_tosspages, Christoph Hellwig
Next by Date:	Re: [PATCH 04/32] xfs: remove xfs_flush_pages, Christoph Hellwig
Previous by Thread:	[PATCH 03/32] xfs: remove xfs_wait_on_pages(), Dave Chinner
Next by Thread:	[PATCH 10/32] xfs: uncached buffer reads need to return an error, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages()