Re: [PATCH 19/32] xfs: factor dir2 block read operations

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 19/32] xfs: factor dir2 block read operations
From:	Ben Myers <bpm@xxxxxxx>
Date:	Wed, 14 Nov 2012 21:09:28 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1352721264-3700-20-git-send-email-david@xxxxxxxxxxxxx>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-20-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Mon, Nov 12, 2012 at 10:54:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> In preparation for verifying dir2 block format buffers, factor
> the read operations out of the block operations (lookup, addname,
> getdents) and some of the additional logic to make it easier to
> understand an dmodify the code.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

This was a difficult review.  I think you have at least three ideas in here
which could be split up.  Please keep the reviewer in mind.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 31/32] xfs: add CRC infrastructure, (continued) Re: [PATCH 31/32] xfs: add CRC infrastructure, Mark Tinguely [PATCH 31/32 V2] xfs: add CRC infrastructure, Dave Chinner [PATCH 28/32] xfs: add pre-write metadata buffer verifier callbacks, Dave Chinner [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Dave Chinner Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Mark Tinguely [PATCH 18/32] xfs: add verifier callback to directory read code, Dave Chinner [PATCH 32/32] xfs: add CRC checks to the log, Dave Chinner Re: [PATCH 32/32] xfs: add CRC checks to the log, Mark Tinguely [PATCH 16/32] xfs: verify btree blocks as they are read from disk, Dave Chinner [PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner Re: [PATCH 19/32] xfs: factor dir2 block read operations, Ben Myers <= Re: [PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner [PATCH 25/32] xfs: add xfs_da_node verification, Dave Chinner [PATCH 29/32] xfs: connect up write verifiers to new buffers, Dave Chinner [PATCH 29/32 V2] xfs: connect up write verifiers to new buffers, Dave Chinner [PATCH 30/32] xfs: convert buffer verifiers to an ops structure., Dave Chinner [PATCH 30/32 V2] xfs: convert buffer verifiers to an ops structure., Dave Chinner Re: [PATCH 00/32] xfs: current queue for 3.8, Ben Myers Re: [PATCH 00/32] xfs: current queue for 3.8, Dave Chinner Re: [PATCH 00/32] xfs: current queue for 3.8, Ben Myers Re: [PATCH 00/32] xfs: current queue for 3.8, Ben Myers

Previous by Date:	Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Mark Tinguely
Next by Date:	Re: [PATCH 00/32] xfs: current queue for 3.8, Ben Myers
Previous by Thread:	[PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner
Next by Thread:	Re: [PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]