Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk

xfs

Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk
From:	Phil White <pwhite@xxxxxxx>
Date:	Mon, 12 Nov 2012 17:09:00 -0800
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1352721264-3700-13-git-send-email-david@xxxxxxxxxxxxx>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-13-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

Dave, you botched a copy & paste here:

On Mon, Nov 12, 2012 at 10:54:04PM +1100, Dave Chinner wrote:
> +     agf_ok = agf->agf_magicnum == cpu_to_be32(XFS_AGF_MAGIC) &&
> +             XFS_AGF_GOOD_VERSION(be32_to_cpu(agf->agf_versionnum)) &&
> +             be32_to_cpu(agf->agf_freeblks) <= be32_to_cpu(agf->agf_length) 
> &&
> +             be32_to_cpu(agf->agf_flfirst) < XFS_AGFL_SIZE(mp) &&
> +             be32_to_cpu(agf->agf_fllast) < XFS_AGFL_SIZE(mp) &&
> +             be32_to_cpu(agf->agf_flcount) <= XFS_AGFL_SIZE(mp) &&
> +             be32_to_cpu(agf->agf_flcount) <= XFS_AGFL_SIZE(mp);

See: 
> -     agf_ok =
> -             agf->agf_magicnum == cpu_to_be32(XFS_AGF_MAGIC) &&
> -             XFS_AGF_GOOD_VERSION(be32_to_cpu(agf->agf_versionnum)) &&
> -             be32_to_cpu(agf->agf_freeblks) <= be32_to_cpu(agf->agf_length) 
> &&
> -             be32_to_cpu(agf->agf_flfirst) < XFS_AGFL_SIZE(mp) &&
> -             be32_to_cpu(agf->agf_fllast) < XFS_AGFL_SIZE(mp) &&
> -             be32_to_cpu(agf->agf_flcount) <= XFS_AGFL_SIZE(mp) &&
> -             be32_to_cpu(agf->agf_seqno) == agno;

-Phil

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 08/32] xfs: make growfs initialise the AGFL header, (continued) [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Rich Johnston Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Christoph Hellwig Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Dave Chinner Re: [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Rich Johnston [PATCH 03/32] xfs: remove xfs_wait_on_pages(), Dave Chinner Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages(), Christoph Hellwig [PATCH 10/32] xfs: uncached buffer reads need to return an error, Dave Chinner [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Phil White <= Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Mark Tinguely [PATCH 09/32] xfs: make buffer read verication an IO completion function, Dave Chinner [PATCH 11/32] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 11/32] xfs: verify superblocks as they are read from disk, Christoph Hellwig [PATCH 14/32] xfs: verify AGFL blocks as they are read from disk, Dave Chinner [PATCH 13/32] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Rich Johnston

Previous by Date:	xfs: Remove boolean_t typedef completely., Thiago Farina
Next by Date:	Re: [patch 2/2 V2] xfstests: xfs_tosspages() test addition, Andrew Dahl
Previous by Thread:	[PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner
Next by Thread:	Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]