Re: [PATCH] xfsdump:fill in bs_forkoff

[Ben Myers <bpm@xxxxxxx>]

Hey Eric,

On Thu, Oct 18, 2012 at 11:02:05PM -0500, Eric Sandeen wrote:
> Upstream, the structure containing bs_forkoff is actually zeroed
> prior to these functions, but when pulling the patch back to an
> older xfsdump, we got checksum errors due to an uninitialized
> bs_forkoff not matching in dump vs. restore.
> 
> So even though forkoff won't be explicitly restored from
> a dump, do explicitly set it in these routines to keep checksums
> happy.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Would you say that this is appropriate for the upcoming release?

Thanks,
        Ben