Re: [PATCH 03/25] xfs: make buffer read verication an IO completion func

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function
From:	Phil White <pwhite@xxxxxxx>
Date:	Mon, 29 Oct 2012 17:55:36 -0700
Cc:	Phil White <pwhite@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20121030004546.GW29378@dastard>
References:	<1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-4-git-send-email-david@xxxxxxxxxxxxx> <20121030002916.GE30227@xxxxxxxxxxxxxxxxxxxx> <20121030004546.GW29378@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Oct 30, 2012 at 11:45:46AM +1100, Dave Chinner wrote:
> > This is OK with me so far, but I have comments on some of the callbacks.
> 
> /me looks around, doesn't find anything...
> 
> The comments must be elsewhere. ;)

You surmised correctly.
 
> BTW, Phil, can you trim away all the bits of the patch you aren't
> commenting on? Having to scroll through hundreds of lines of quoted
> email to find your replies is a little slow, and it's quite easy to
> miss comments when they are widely spread apart. Most people just
> quote the patch hunk they are making the comment about to avoid this
> problem....
 
Will do.  Sorry about that!

-Phil

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/25, V3] xfs: metadata buffer verifiers, Dave Chinner [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Dave Chinner Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Christoph Hellwig Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Phil White [PATCH 04/25] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 04/25] xfs: uncached buffer reads need to return an error, Christoph Hellwig Re: [PATCH 04/25] xfs: uncached buffer reads need to return an error, Phil White [PATCH 03/25] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White <= [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Phil White [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Dave Chinner Re: [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Phil White [PATCH 05/25] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 05/25] xfs: verify superblocks as they are read from disk, Phil White [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Phil White Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Dave Chinner

Previous by Date:	Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White
Next by Date:	Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Phil White
Previous by Thread:	Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Dave Chinner
Next by Thread:	[PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]