Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary supe

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks
From:	Phil White <pwhite@xxxxxxx>
Date:	Mon, 29 Oct 2012 17:17:50 -0700
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1351146854-19343-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Oct 25, 2012 at 05:33:50PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When updating new secondary superblocks in a growfs operation, the
> sueprblock buffer is read from the newly grown region of the
> underlying device. This is not guaranteed to be zero, so violates
> the underlying assumption that the unused parts of superblocks are
> zero filled. Get a new buffer for these secondary superblocks to
> ensure that the unused regions are zero filled correctly.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---
> [ snip ]

Looks good to me too. 

Reviewed-by: Phil White <pwhite@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, (continued) Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Christoph Hellwig Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Phil White [PATCH 04/25] xfs: uncached buffer reads need to return an error, Dave Chinner Re: [PATCH 04/25] xfs: uncached buffer reads need to return an error, Christoph Hellwig Re: [PATCH 04/25] xfs: uncached buffer reads need to return an error, Phil White [PATCH 03/25] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Dave Chinner Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner Re: [PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Phil White <= [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Dave Chinner Re: [PATCH 09/25] xfs: verify inode buffers as they are read from disk, Phil White [PATCH 05/25] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 05/25] xfs: verify superblocks as they are read from disk, Phil White [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Phil White Re: [PATCH 07/25] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 11/25] xfs: verify dquot blocks as they are read from disk, Phil White [PATCH 14/25] xfs: verify dir2 block format buffers, Dave Chinner

Previous by Date:	Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function, Phil White
Next by Date:	Re: [PATCH 02/25] xfs: invalidate allocbt blocks moved to the free list, Phil White
Previous by Thread:	[PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner
Next by Thread:	[PATCH 09/25] xfs: verify inode buffers as they are read from disk, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]