| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 13 Oct 2012 11:52:05 -0400 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx>, nscott@xxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx> |
| In-reply-to: | <5078432B.6050501@xxxxxxxxxx> |
| References: | <5078432B.6050501@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 12, 2012 at 11:19:55AM -0500, Eric Sandeen wrote: > xfs_quota has long set XFS_XFLAG_PROJINHERIT on all files, > and tested for presence on all files. However, Dave's semi-recent > xfs_repair update is now flagging this as an error: I think we should rever that part of the repair patch. While there really is not point to have XFS_XFLAG_PROJINHERIT set on non-directory files we have been setting it for year, so repair should cope with that. I'd also like to have a test checking that repair does not complain about XFS_XFLAG_PROJINHERIT being set on a non-directory to verify this. For the future I'm fine with not setting it on non-directories anymore, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx> for this patch after a slight update to the commit message. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: File system corruption, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 22/23] xfs: add pre-write metadata buffer verifier callbacks, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |